[ http://issues.apache.org/jira/browse/ADFFACES-152?page=all ]
Adam Winer updated ADFFACES-152:
--------------------------------
Status: Resolved (was: Patch Available)
Resolution: Fixed
Assignee: Adam Winer
Fixed. However, I'm only calling ExternalContext.
If there is a need to call the ViewHandler (I don't believe it should be
necessary), that should get taken up in another bug, because across all of
Trinidad we only go through the ExternalContext.
> HtmlCommandButtonRenderer does not encode image url
> ---------------------------------------------------
>
> Key: ADFFACES-152
> URL: http://issues.apache.org/jira/browse/ADFFACES-152
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Environment: MyFaces 1.1.4-snapshot from
> http://people.apache.org/builds/myfaces/core-1.1.x/
> Reporter: Martin Koci
> Assigned To: Adam Winer
> Priority: Critical
> Attachments: HtmlCommandButtonRenderer.java.patch
>
>
> HtmlCommandButtonRenderer is rendering image attribute without using
> encodeUrl on ExternalContext. I leads to disappearance of all button images,
> because we use <h:commandButton image="/imageServlet/imageName.gif" />
> everywhere.
> Proper encoding of URL can be:
> String src =
> context.getApplication().getViewHandler().getResourceURL(context, imageSrc);
> writer.writeURIAttribute("src",
> context.getExternalContext().encodeResourceURL(src), "image");
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
