[ http://issues.apache.org/jira/browse/ADFFACES-153?page=comments#action_12431997 ] Jeanne Waldman commented on ADFFACES-153: -----------------------------------------
I applied the patch. I noticed that we use html markup <b> for the accesskeys on command/goButton. It would be nice to add this feature to those components, too, so that we can more easily expose skinning hooks to style the accessKey on these components. > RenderAccessKeyText in AccessKeyUtils class currently uses HTML element to > decorate accessKey, rather than CSS > -------------------------------------------------------------------------------------------------------------- > > Key: ADFFACES-153 > URL: http://issues.apache.org/jira/browse/ADFFACES-153 > Project: MyFaces ADF-Faces > Issue Type: Improvement > Reporter: Yee-Wah Lee > Priority: Minor > Attachments: trunk.patch > > > The method RenderAccessKeyText in > org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.AccessKeyUtils > currently takes a string argument, "highlightElement". It uses the > highlightElement to create a HTML tag around the AccessKey character, e.g. > RenderAccessKeyText (fc, "Go to sitemap",1,"b") produces > <b>G</b>o to sitemap > Propose changing the usage of the highlightElement to be the name of a CSS > class instead for flexibility. Also, the most common convention is to > underline the access key, but the <U> element, which would be produced with > existing code, is deprecated in HTML 4.0. With the change, output would then > be: > RenderAccessKeyText (fc, "Go to sitemap",1,"AccessKeyClass") produces > <span class="AccessKeyClass">G</span>o to sitemap > The other overloads in the class which did not specify any value for > highlightElement will be modified to pass a default class, which has style > "text-decoration:underline" and is defined in base-desktop.xss -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
