[ http://issues.apache.org/jira/browse/ADFFACES-171?page=comments#action_12434821 ] Jeanne Waldman commented on ADFFACES-171: -----------------------------------------
Getting rid of these constants is not urgent for the work I need to do, and I see quite a few renderers use the embed attribute. Except I'd like to get rid of the ALIGN attribute. Not only is it deprecated (http://www.w3.org/TR/html4/struct/objects.html#h-13.7.4), but it is widely considered bad practice to write any styling in html (so this also applies to setting things like width, height and valign to td's and such). > Get rid of Icon public constants, like Icon.EMBEDDED_KEY from the Icon API. > --------------------------------------------------------------------------- > > Key: ADFFACES-171 > URL: http://issues.apache.org/jira/browse/ADFFACES-171 > Project: MyFaces ADF-Faces > Issue Type: Improvement > Components: Skinning > Reporter: Jeanne Waldman > Assigned To: Jeanne Waldman > > The Icon class has public constants, like Icon.EMBEDDED_KEY and Icon.ID_KEY > that the renderer can set. Instead the renderer can set any attributes it > wants itself on an element around the icon. That way the Icon will render > only information that it gets from the constructor or the skinning file. This > will separate the renderer from the icon. This will be very useful for > client-side rendering of icons. The skin's icons can be sent to the client, > and we don't have to worry that an icon key could render something different > depending upon its renderer. > To start this task, I plan to get rid of the use of the Icon constants and > then I will get rid of the constants themselves. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
