[
http://issues.apache.org/jira/browse/ADFFACES-228?page=comments#action_12443121
]
Adam Winer commented on ADFFACES-228:
-------------------------------------
Comments on the patch:
- _renderNavigationItem() and _renderNonOverlappingItem() already have
RenderingContexts; no need to call getCurrentInstance()
- Some opening braces ('{') are placed on the same line as the code; this is
against Trinidad coding standards.
- In general, -1 to adding "isPDA()" checks, especially the way it's done in
_renderNonOverlappingItem(). This would be much better handled
by creating a subclass of NavigationPaneRenderer in the core.pda package that
handles
this rendering distinction. It'd be OK to add a couple of protected methods
to the
base NavigationPaneRenderer class to enable this.
> fix navigationPane on PDAs
> --------------------------
>
> Key: ADFFACES-228
> URL: http://issues.apache.org/jira/browse/ADFFACES-228
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Environment: PDA
> Reporter: Piyush Hari
> Priority: Minor
> Attachments: patch_oct10_01_31AM_navigationPane_pda.patch
>
>
> The navigationPane component creates a series of navigation items
> representing one level in a navigation hierarchy. These items may either be
> added as children or a menu model may be bound to the navigationPane
> component.
> Currently, on a PDA, navigationItem in a "tabs" , "bar" and "button" mode
> does not display properly. Childern and separators get rendered in a new line
> and that occupies a lot of real screen estate and at the same time, is
> confusing to the user.
> I plan to fix this.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
