[ http://issues.apache.org/jira/browse/ADFFACES-283?page=all ]

Arjuna Wijeyekoon updated ADFFACES-283:
---------------------------------------

    Attachment: base64stream_cleanup.patch

added a close() and flush() method to Base64OutputStream.
deprecated the finish() method.

added close() method to Base64InputStream.

cleanedup CoreResponseStateManager to take advantage of the close method on 
Base64OutputStream.

> Base64OutputStream needs a cleanup
> ----------------------------------
>
>                 Key: ADFFACES-283
>                 URL: http://issues.apache.org/jira/browse/ADFFACES-283
>             Project: MyFaces ADF-Faces
>          Issue Type: Bug
>            Reporter: Arjuna Wijeyekoon
>         Attachments: base64stream_cleanup.patch
>
>
> The public class:
> org.apache.myfaces.trinidad.util.Base64OutputStream
> needs to change to better fit the OutputStream api:
> 1. it has a finish() method instead of a close() method.
> 2. it doesn't have a close() method at all. It should have one that
> delegates to the
> underlying Writer
> 3. it doesn't have a flush() method that delegates to the underlying writer.
> I will upload a patch

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to