[ http://issues.apache.org/jira/browse/ADFFACES-292?page=comments#action_12450149 ] Jeanne Waldman commented on ADFFACES-292: -----------------------------------------
I implemented this feature. This allows trinidad-skins.xml files to be in jars. Also, I added the <skin-addition> <skin-id/> <style-sheet-name/> </skin-addition> elements to trinidad-skins.xml so that custom component developers can add their skin selectors/properties to an existing skin. I added information about this in the Skinning FAQ wiki. http://wiki.apache.org/myfaces/Trinidad_Skinning_FAQ > Allow registering stylesheets on a particular skin via an xml config file > ------------------------------------------------------------------------- > > Key: ADFFACES-292 > URL: http://issues.apache.org/jira/browse/ADFFACES-292 > Project: MyFaces ADF-Faces > Issue Type: Improvement > Reporter: Jeanne Waldman > Assigned To: Jeanne Waldman > > Background: > > Let's say a custom component developer created some new components. He > > wants those components to "fit in" with the > > 'simple' skin. He also wants them to "fit in" with the 'minimal' skin > > or any other public skin out there. He doesn't have access to the files > > where we > > have this information -- our base-desktop.xss, simple-desktop.xss, > > simple-pda.xss, etc. > > > > With Trinidad's Skin API, he can call the > > skin.registerStyleSheet > > ("styles/myCustomComponentsSimpleDesktop.css") > > method on the skin instance. Aside: I'm not sure *when/where* the custom > > component developer would do this, because it would need to be after we've > > registered our base skins and any skin extensions, so presumably it > > would need to be after the TrinidadFilter. > > > > It would be much nicer for the custom component developer if all he has > > to do is create an .xml file and stick it in the META-INF > > of his jar file. Then we'll parse the xml file and register the > > stylesheets with the skins for him. > Conclusion: > On the list, we decided to add a <skin-addition> element to the > trinidad-skins.xml file. > We definitely want to allow these skin-additions to be in a .jar file, > therefore we'll need trinidad-skins.xml to be able to be in a jar file. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
