inputDate should not render icon if 'chooseId' specified
--------------------------------------------------------

                 Key: ADFFACES-317
                 URL: http://issues.apache.org/jira/browse/ADFFACES-317
             Project: MyFaces ADF-Faces
          Issue Type: Improvement
            Reporter: Danny Robinson
            Priority: Minor


The current <tr:inputDate> implementation always renders an icon immediately 
following the input field.  However, if you specify a <tr:chooseDate> to render 
the calendar in-page, it shouldn't render the icon.  A simple patch to 
SimpleInputDateRenderer fixes this (below).

PATCH to 
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.SimpleInputDateRenderer

  @Override
  protected void renderAfterTextField(
    FacesContext context,
    RenderingContext arc,
    UIComponent component,
    FacesBean bean) throws IOException
  {
      // Only render the icon if chooseId is not specified.
      if (_getChooseId(arc) == null)
          super.renderAfterTextField(context, arc, component, bean);
  }

By the way, this fix will cause CoreRenderKitTest to fail, so will require an 
update to the expected/golden output for this component.  Sorry - I'm not yet 
familiar enough to do this.

Thanks,

Danny


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to