[ 
https://issues.apache.org/jira/browse/ADFFACES-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12492094
 ] 

Adam Winer commented on ADFFACES-466:
-------------------------------------

The latest patch adds global synchronization to application of changes, which 
is excessive.

> Issues in change persistence framework code
> -------------------------------------------
>
>                 Key: ADFFACES-466
>                 URL: https://issues.apache.org/jira/browse/ADFFACES-466
>             Project: MyFaces ADF-Faces
>          Issue Type: Bug
>    Affects Versions: 2.0.0-incubating-plugins-SNAPSHOT, 
> 2.0.0-incubating-core-SNAPSHOT, 1.0.1-incubating-plugins-SNAPSHOT, 
> 1.0.1-incubating-core-SNAPSHOT
>            Reporter: K SRINATH REDDY
>            Priority: Critical
>             Fix For: 2.0.0-incubating-plugins-SNAPSHOT, 
> 2.0.0-incubating-core-SNAPSHOT, 1.0.1-incubating-plugins-SNAPSHOT, 
> 1.0.1-incubating-core-SNAPSHOT
>
>         Attachments: trunk.patch, trunk_latest.patch
>
>
> 1. The datastructures used in the SessionChangeManager are not synchronized
> 2. The _getUniqueIdForComponent() method in BaseChangeManager doesn't return 
> the unique ID in the component tree instead it returns the unique id in the 
> containing NamingContainer
> 3.  In the AddChildComponentChange, if the child with the already existing ID 
> is added, the child is being removed and the new child is added which is 
> faulty.
> 4. The changes are applied in each of the restoreView phase of the lifecycle 
> which is not needed and also impacts the performance. the changes must be 
> applied only on the creation

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to