That's a good question. We do have a lot of stuff in internal so these
areas should be clear (and yet we see people going in an using them, but at
least they should know they are on their own).

The plugin classes are something that in hindsight should have been
internal from day one. I think they weren't because I didn't expect people
to go in and start accessing them.

Based on how you apply a plugin using a name that hides the actual class
and how the DSL hides the underlying implementation, I don't think it's
standard practice in Gradle to access the underlying classes.

Note that we do publish docs now (though it's not fully integrated in
developer.android.com yet), and the Plugin class is not part of it. The doc
is missing somethings and we're fixing it, but it's stuff that you see the
current API/DSL give you access to, so you expect it to be public. The only
way to know about the plugin class is to look at the source code and that
should be a warning already.

I think we will move all of these to internal packages for 1.1. It's better
to break things now than later when there's an even wider adoption.


On Tue, Feb 3, 2015 at 9:40 PM, Jake Wharton <[email protected]> wrote:

> Ah, only one of our instances is using that one specifically.
>
> How do we differentiate what is considered public API or not?
>
>
> On Tue Feb 03 2015 at 4:18:50 PM Artem Zinnatullin <
> [email protected]> wrote:
>
>> Filed a bug on Kotlin issue tracker
>> https://youtrack.jetbrains.com/issue/KT-6729
>>
>>
>> On Wednesday, February 4, 2015 at 2:58:08 AM UTC+3, Artem Zinnatullin
>> wrote:
>>>
>>> Hello ADT team, I wanted to try Android Gradle plugin v1.1.0-rc1 because
>>> of Unit tests support, but Kotlin Gradle plugin 
>>> 'org.jetbrains.kotlin:kotlin-gradle-plugin:0.10.195'
>>> failing the build because of changes in Android one:
>>>
>>> Execution failed for task ':app:compileDevEnvDebugKotlin'.
>>>
>>> > No signature of method: 
>>> > com.android.build.gradle.AppPlugin.getBootClasspath()
>>> is applicable for argument types: () values: []
>>>
>>> Here is the problem in Kotlin Gradle plugin source "link
>>> <https://github.com/JetBrains/kotlin/blob/master/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/plugin/android/AndroidGradleWrapper.groovy#L15>
>>> "
>>>
>>> As I see, BasePlugin now doesn't provide getBootClasspath any more.
>>>
>>> What is more correct: return method to BasePlugin or fix Kotlin plugin?
>>>
>>>  --
>> You received this message because you are subscribed to the Google Groups
>> "adt-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to [email protected].
>> For more options, visit https://groups.google.com/d/optout.
>>
>  --
> You received this message because you are subscribed to the Google Groups
> "adt-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to [email protected].
> For more options, visit https://groups.google.com/d/optout.
>



-- 
Xavier Ducrohet
Android SDK Tech Lead
Google Inc.
http://developer.android.com | http://tools.android.com

Please do not send me questions directly. Thanks!

-- 
You received this message because you are subscribed to the Google Groups 
"adt-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to