Hmm, interesting.. I think, I have to update a keyword.. Hmm that's
a criterion.. Let me look at that.
I click on "CriterionService" (http://www.google.com/apis/adwords/
developer/CriterionService.html) and then I click on
"updateCriteria"...
And I see this:
Required fields for each criterion:
* id: The ID of the Criterion. The Criterion must already exist.
* adGroupId: The ID of the AdGroup owning this Criterion. This
field is not mutable - you may not move a Criterion to another
adgroup.
Which one would think (or I would think), "they say these are the
required fields so they must the required fields..."
I would expect that the note about additional required fields would be
in the "required fields" section.. Wouldn't you?
Perhaps you should just say something like, "you have to read another
part of the documentation, but we won't tell you what it is, or your
code will fail... If you just follow the documentation for
'updateCriteria' your 'updateCriteria' call will fail!"
---------
BUT: While you're fixing documentation bugs, are you aware that you
have mis-capitalized "InActive" all over the place? It should be
"Inactive"- as that's what you pass back.. (for those of us in a case-
sensitive world)
-tim
On Sep 29, 1:17 pm, AdWords API Advisor <[EMAIL PROTECTED]>
wrote:
> Hello Tim,
>
> I believe that language is in there to indicate that setting the
> criterionType value is only one way of specifying the type of
> Criterion you're dealing with, as per the note at the top of the page:
>
> Note: For statically typed languages, such as Java, create an instance
> of Website. For dynamically typed languages such as Perl and Python,
> create a Criterion data object. Then either specify the xsi:type
> attribute as Website or set the criterionType field to Website.
>
> So theoretically, at least, setting the appropriate xsi:type
> attribute should mean that the criterionType doesn't need to be
> specified. I need to dig up some sample code for a client library in a
> language that actually takes the xsi:type approach rather than the
> criterionType approach to make sure that that still applies. If for
> some reason the AdWords API is no longer accepting xsi:type as an
> alternative method then I'll ask to have the docs updated.
>
> Cheers,
> -Jeff Posnick, AdWords API Team
>
> On Sep 28, 9:49 am, timprepscius <[EMAIL PROTECTED]> wrote:
>
> > it would be useful to have:
>
> > must set criterionType when updating criteria, even though the
> > adgroupId and Id should theoretically specify an exact item.
>
> > criterionType CriterionType
> > The concrete type of this criterion. Generally, this attribute is read
> > only, but **********may*********** (not really may, should be 'must')
> > be set by scripting languages to indicate a concrete type.
>
> > Values are:
>
> > * Website
> > * Keyword
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"AdWords API Forum" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/adwords-api?hl=en
-~----------~----~----~----~------~----~------~--~---