On Sat, Feb 06, 2010 at 11:53:10AM +0100, Olivier Boudeville wrote:
> Hello again,
>
> Maybe it would just be a matter to add, next to the AG_TAILQ_HEAD
> definition in queue.h, something like:
>
> #define AG_ANONYMOUS_TAILQ_HEAD(t) struct { struct t *tqh_first; /*
> first element */ struct t **tqh_last; /* addr of last next element */ }
Yes, that fixes it.
> (would'nt it be safer to use '(t)' instead of 't' in all these macros?)
It would expand to "struct (foo)", which isn't valid C code. You're always
expected to pass a simple type name as t.
> If a 1.3.5 fixed version could be released soon (unless the upcoming 1.4
> is to be released at short term?), I may be able to send patches to
> correct these small issues. Unless one should focus only in the 1.4 version?
1.4 is going to be released very shortly. We really need as many people
as possible to test the current SVN because this is a major release.
> By the way, in http://libagar.org/contribute.html.fr the "signaler les
> bogues" link is dead.
Corrected, thanks.
>
> Best regards,
>
> Olivier.
>
> Olivier Boudeville a écrit :
> > Hello,
> >
> > In Agar-1.3.4, in agar/core/class.h line 39 (line 40 in current SVN) the
> > AG_TAILQ_HEAD macro has no first argument specified, which makes gcc
> > (version 4.4.1 on Ubuntu, with some warnings enabled) complain:
> >
> > '''error: invoking macro AG_TAILQ_HEAD argument 1: empty macro arguments
> > are undefined in ISO C90 and ISO C++98"
> >
> > This is true also for:
> > - agar/core/object.h line 62, 63 and 68
> > - agar/core/dso.h line 20
> > - agar/gui/widget.h line 98
> > - window.h line 94
> > - label.h line 65
> > - tlist.h line 72
> > - file_dlg.h line 47, 78
> > - graph.h line 79, 80
> > - notebook.h line 43
> >
> > Same thing for the AG_SLIST_HEAD macro:
> > - table.h line 147
> > - text_cache.h line 14
> >
> > Finally, in agar/gui/graph.h, in the ag_graph_vertex_style enum there is
> > a comma after AG_GRAPH_CIRCLE which should preferably be removed
> > (otherwise: "error: comma at end of enumerator list").
> >
> > Could all these minor points be fixed? I am volunteering to test any
> > pre-release of Agar archive, to iron out these small compilation issues,
> > if it can help.
> >
> > Thanks in advance,
> > Best regards,
> >
> > Olivier Boudeville.
_______________________________________________
Agar mailing list
[email protected]
http://libagar.org/lists.html
