On Thu, Jul 01, 2010 at 07:43:25PM +0200, Olivier Boudeville wrote:
> Hi,
> 
> Maybe a short summary of global variables exposed by Agar could be 
> useful: when needing to check whether OpenGL is enabled (done previously 
> with agView->opengl), finding out what should be used in 1.4 is a bit 
> tricky. A guess is that the corresponding call would be 
> 'agDriverSw->flags & AG_DRIVER_OPENGL'? (when using the sdlgldriver)

The proper test would be "agDriverOps->flags & AG_DRIVER_OPENGL", but
let me add a function for that (my solution to everything). We'll call
it AG_UsingGL().

> Maybe for the issue I raised previously, I should develop a specific 
> AG_DriverSw subclass to separate the (SDL) event polling from the 
> conversion to Agar events?

I think that would have been overkill..

> Some other minor remarks:
>     - there are commas at the end of some enumerator lists, which break 
> builds when treating warnings as errors, in 
> include/agar/agar/gui/widget.h:82
>     - AG_ViewCapture() is declared twice, in 
> include/agar/agar/gui/gui.h:50 and in include/agar/agar/gui/drv.h:185

Fixed, thanks!

>     - build is fine if using the following configure options: 
> ..../configure --prefix=[..]/agar-1.4.0-newer --disable-network 
> --disable-threads --disable-server --enable-gui --enable-utf8 --with-gl 
> --with-jpeg --with-freetype
> 
> But adding --disable-legacy results in:
> 
> make[2]: entrant dans le répertoire «[..]/agar-1.4.0/dev »
> ...../mk/libtool/libtool --mode=compile /usr/bin/gcc  -D_AGAR_INTERNAL 
> -D_BSD_SOURCE -I[..]/agar-1.4.0/include -I[..]/agar-1.4.0/include/agar 
> -D_AGAR_DEV_INTERNAL -I[..]/SDL-1.2.14/include/SDL -D_GNU_SOURCE=1 
> -D_REENTRANT   -I/usr/include   -o object.lo -c object.c
> rm -f .libs/object.lo
> /usr/bin/gcc -D_AGAR_INTERNAL -D_BSD_SOURCE -I[..]/agar-1.4.0/include 
> -I[..]/agar-1.4.0/include/agar -D_AGAR_DEV_INTERNAL 
> -I/[..]/SDL-1.2.14/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT 
> -I/usr/include -c object.c  -fPIC -DPIC -o .libs/object.lo
> object.c:59: error: 'AG_OBJECT_RELOAD_PROPS' undeclared here (not in a 
> function)
> make[2]: *** [object.lo] Erreur 1

Yes, that one was fixed a while ago, --disable-legacy should build
cleanly now.


_______________________________________________
Agar mailing list
[email protected]
http://libagar.org/lists.html

Reply via email to