I continue my console project and patching Agavi to suit console use better :)

Plain text formating to AgaviException::printStackTrace:
http://veikkomakinen.com/agavi/source.php?file=AgaviException.class.php&hidelineno=true
http://veikkomakinen.com/agavi/AgaviException.diff.txt

ConsoleController should also be updated to use plain formating (lines 89 and 96 "$e->printStackTrace('plain')" ).

Furthermore I also suggest that Controller::inCLI() should be made static and all agavi.php's catch blocks should check this and call for plain text formating where more appropriate :)

if (Controller::inCLI()) {
  $e->printStackTrace('plain');
}
else {
  $e->printStackTrace();
}


-veikko

_______________________________________________
agavi-dev mailing list
[email protected]
http://labworkz.com/cgi-bin/mailman/listinfo/agavi-dev

Reply via email to