Veikko,
Thanks for you help with Agavi and pointing out the $require array, that
help immensely.
I have finally finished looking over all your code and I now have a
better understanding of Agavi. I agree with all your code changes
except one. In one of your emails to the agavi-dev list you mentioned:
".... Just abstract function autoStart(); to Storage.class.php, ....."
I don't think that is necessary because you check to make sure it is an
instance of SessionStorage before you call the autoStart method.
if ($this->storage instanceof SessionStorage) {
$this->storage->autoStart();
}
However, everything else you suggested will eliminate the redundancy
checks for checking to see if a session has already started before
calling session_start().
I also like the cookie stuff as well and can envision its usefulness.
-Wes
Veikko Mäkinen wrote:
Veikko Mäkinen wrote:
Hey folks,
SessionStorage::initialize's auto_start implementation causes a small
problem when using an inheriting class (like PostgreSQLSessionStorage
or my CreoleSessionStorage
[http://veikkomakinen.com/agavi/source.php?file=SessionStorage.class.php&hidelineno=true]).
This would require small changes in Context.class.php.
I fixed the auto_start problem by adding autoStart method to
SessionStorage and calling it from Context::initialize. Links to
source and diffs against trunk rev 262 (newest for now):
http://veikkomakinen.com/agavi/source.php?file=Context.class.php&hidelineno=true
http://veikkomakinen.com/agavi/source.php?file=SessionStorage.class.php&hidelineno=true
http://veikkomakinen.com/agavi/Context.diff.txt
http://veikkomakinen.com/agavi/SessionStorage.diff.txt
My SessionStorage also introduces cookie parameter handling and little
more documentation.
What do you think?
-veikko
_______________________________________________
agavi-dev mailing list
[email protected]
http://labworkz.com/cgi-bin/mailman/listinfo/agavi-dev
--
James "Wes" Hays
Great Basin Development
P.O.Box 3503, Reno, Nevada 89505
Cell: (775) 745-3013
[EMAIL PROTECTED]
http://www.gbdev.com
_______________________________________________
agavi-dev mailing list
[email protected]
http://labworkz.com/cgi-bin/mailman/listinfo/agavi-dev
