Felix Gilcher wrote:
Hi,

caution, there is a bug in that diff: the elseif condition will
always be true as it assigns the value 'int' to the variable $type
which should always succeed.

Ups, busted... didn't test my code before sending :)

assignment]. A second (but minor thing): I'd rather use typecasts
than regexps for this kind of checking, as regular expressions carry
the overhead of invoking the regexp engine.

I'd rather use typecasts too, but I'm yet to see a typecast test that wouldn't let some obvious non-integers pass the test. I took our test and tried to make it work but wasn't able...

test:
http://veikkomakinen.com/temp/test2.txt

result:
http://veikkomakinen.com/temp/result.txt


-veikko

_______________________________________________
agavi-dev mailing list
[email protected]
http://labworkz.com/cgi-bin/mailman/listinfo/agavi-dev

Reply via email to