My replies are inline again. I discussed this stuff with Veikko,
changed some more things upon his approval, and now we're ready. It's
your turn, Bob :) We should roll an RC as soon as possible after the
merge, I will start writing up a list of changes and release notes
tomorrow.
- David
Am 26.11.2005 um 22:38 schrieb David Zülke:
Hi Veikko,
replies inline.
* Plain text formating to AgaviException::printStackTrace
http://trac.agavi.org/trac.cgi/changeset/271
This is good, but you should alter ConsoleController::dispatch() so
it uses the formatting instead of HTML.
Whoops. It's doing that already ;)
* Cookie support to WebRequest
http://trac.agavi.org/trac.cgi/changeset/273
Why are the cookie options set as an array? IMO, it should behave
like set_cookie();
I changed this as discussed on IRC. Same parameter order as PHP's
setcookie(), only difference is that we're using a lifetime instead
of a destination expiry timestamp.
* fixed __autoload to behave nicely with 3rd party autoloading
mechanisms using class_exists
http://trac.agavi.org/trac.cgi/changeset/276
I'm not sure about this one. It means that exceptions will not be
thrown, leaving users clueless regarding why their stuff doens't
work...
You were right. Exceptions thrown in __autoload() cannot be caught
according to the docs anyway. Don't like it that much for the reasons
above, but it makes sense.
The rest is nice, tho. We already talked on IRC about some
changesets being screwed up, files were replaced entirely, this
will make merging difficult and is likely the reason why I
encountered so many conflicts when I attempted to merge my changes
over to your branch.
This apparently was just a display problem of Trac's Diff Viewer.
Also, could you please change the version numbers to @since 0.10.0?
Better than 0.10.0-DEV
You fixed it, thanks ;I
- David_______________________________________________
agavi-dev mailing list
[email protected]
http://labworkz.com/cgi-bin/mailman/listinfo/agavi-dev
