I would go ahead. Bassel is away for an indeterminate amount of time. Just please test your code :)
Jon On Fri, Mar 23, 2012 at 3:19 PM, Jakub Jankiewicz <[email protected]> wrote: > I can commit, but I first ask Bassel on mailing list and directly, if > Mac that he mention have magic_quotes_gpc enabled since he added > stripslashed (because Mac add slashes) which I removed then he added > them back in and then Roger remove it again, because if they was enabled > this will work on Mac, and this annoying bug with Javascript will be > fixed too. > > I wait few days if he did not respond I will commit. > > On Fri, 23 Mar 2012 01:25:25 -0000 > rejon <[email protected]> wrote: > >> great, did you commit it? >> >> On Fri, Mar 23, 2012 at 2:11 AM, Jakub Jankiewicz >> <[email protected]> wrote: >> > It seams that problem was with magic_quotes_gpc >> > >> > this code in index.php fix the issue >> > >> > if (get_magic_quotes_gpc()) { >> > function stripslashes_gpc(&$value) { >> > $value = stripslashes($value); >> > } >> > array_walk_recursive($_GET, 'stripslashes_gpc'); >> > array_walk_recursive($_POST, 'stripslashes_gpc'); >> > array_walk_recursive($_COOKIE, 'stripslashes_gpc'); >> > array_walk_recursive($_REQUEST, 'stripslashes_gpc'); >> > } >> > >> > found here >> > http://www.php.net/manual/en/security.magicquotes.disabling.php >> > >> > ** Changed in: aikiframework >> > Status: New => Invalid >> > >> > -- >> > You received this bug notification because you are subscribed to >> > aikiframework. >> > https://bugs.launchpad.net/bugs/962055 >> > >> > Title: >> > Quote is not remove from argument in extension call >> > >> > To manage notifications about this bug go to: >> > https://bugs.launchpad.net/aikiframework/+bug/962055/+subscriptions >> >> > > -- > Jakub Jankiewicz > twitter: @jcubic > www: http://jcubic.pl > > -- > You received this bug notification because you are subscribed to > aikiframework. > https://bugs.launchpad.net/bugs/962055 > > Title: > Quote is not remove from argument in extension call > > To manage notifications about this bug go to: > https://bugs.launchpad.net/aikiframework/+bug/962055/+subscriptions -- Jon Phillips 王✳爻气 http://fabricatorz.com ✳ skype: kidproto ✳ irc: rejon +1.415.830.3884 (global) ✳ +86-187-1003-9974 (beijing) -- You received this bug notification because you are a member of Aiki Framework Admins, which is subscribed to aikiframework. https://bugs.launchpad.net/bugs/962055 Title: Quote is not remove from argument in extension call Status in Aiki Framework: Invalid Bug description: if you execute extension as this (script( $aiki->json->rpc('(!(1)!)'); )script) and call with /rpc/system it pass system' into extension the same is if you put double quotes. quick fix is to not use quotes, Aiki now handle double open parentheses properly in this case (script( $aiki->json->rpc((!(1)!)); )script) but this should be fix in Aiki To manage notifications about this bug go to: https://bugs.launchpad.net/aikiframework/+bug/962055/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~aikiframework.admins Post to : [email protected] Unsubscribe : https://launchpad.net/~aikiframework.admins More help : https://help.launchpad.net/ListHelp
