Will it not be a bit confusing to have samples for different components int one place?
Alek On Wed, Jul 27, 2011 at 2:10 PM, Lahiru Gunathilake <[email protected]>wrote: > Hi Thilina, > > Yes if we put it in to a separate module or to distribution we can build > the > samples and but it in to bin directory of each sample and ship the jars > too. > This will be useful if some user wants the jars and want to run it without > using ant. > > Regards > Lahiru > > On Wed, Jul 27, 2011 at 12:45 PM, Thilina Gunarathne <[email protected] > >wrote: > > > How about a separate samples module? Also we need to make sure samples > are > > part of the build, so that they won't be broken (at least no compile > > errors).. > > > > thanks, > > Thilina > > > > On Wed, Jul 27, 2011 at 12:02 PM, Lahiru Gunathilake <[email protected]> > > wrote: > > > Hi Alek, > > > > > > I am +1 to compile the samples and put the jar in to a lib directory > for > > > each sample, at that point we can get to know during the build time > > weather > > > there are issue in samples (But in practical case people will not use > > those > > > jar files, they will simply run the ant script in sample directory). > > > > > > My suggestion is to put these samples in to distributions directory > > rather > > > keeping them in each modules directories. With current model it's not > > nice > > > to keep another set of java files outside src directory in each > > component. > > > > > > Regards > > > Lahiru > > > > > > On Wed, Jul 27, 2011 at 11:42 AM, Aleksander Slominski < > [email protected] > > >wrote: > > > > > >> I think they should be setup so they are compiled. I do not knwo > maven > > but > > >> in eclipse youc an specify multiple source directories and that shoudl > > >> allow > > >> to compile and run samples. > > >> > > >> Is there the same problem for unit tests? > > >> > > >> Alek > > >> > > >> On Wed, Jul 27, 2011 at 10:49 AM, Lahiru Gunathilake < > [email protected] > > >> >wrote: > > >> > > >> > Hi Devs, > > >> > > > >> > I have seen that samples in ws-messenger is scattered and they are > in > > >> each > > >> > module, when you import the code in to an IDE its not under > > src/main/java > > >> > directory so they do not looks like java class files. Normally they > > are > > >> not > > >> > compiled during the build time, users have to compile them and run > > them > > >> > with > > >> > the distribution then it works out of the box. So I keeping them in > > >> > distribution directory (all the samples for all the modules), so if > > >> someone > > >> > wants to look in to samples and do a modification, they can simply > > open > > >> the > > >> > samples and do that. > > >> > > > >> > I have seen this in other projects and they are always keep the > > samples > > >> > with > > >> > the distribution. > > >> > > > >> > WDYT ? > > >> > > > >> > Regards > > >> > Lahiru > > >> > > > >> > > > > > > > > > > > -- > > https://www.cs.indiana.edu/~tgunarat/ > > http://www.linkedin.com/in/thilina > > http://thilina.gunarathne.org > > >
