On Tue, Nov 10, 2015 at 7:59 AM, Barret Rhoden <[email protected]> wrote:
> Two checkpatch complaints: > Fixed those. Same branch. WARNING: quoted string split across lines > #47: FILE: kern/src/ktest/pb_ktests.c:2214: > + "kernel -root=/foo -simple -num=123 -quoted='abc \\'' > -dup=311 -dup='akaros' " > + "-inner=-outer -outer=-inner=xyz"; > > This one is probably okay, though I got a little confused with the 'abc > \\''. are \s the escapes, and if so, are we handling the '' correctly for > the quoted case? > Yes, it handles that correctly. Added a test case for that. > + /* We need to copy the command line in a permanent buffer, > since the > > + * multiboot memory where it is currently residing will be > part of the > > + * free boot memory later on in the boot process. > > + */ > > More of an FYI, but we have no plans to ever try and free boot memory. > The memory where the mboot cmdline resides, is part of the one that gets handed over as free. Ask me how I know ... 😀 > + strncpy(boot_cmdline, cmdln, sizeof(boot_cmdline)); > > + boot_cmdline[sizeof(boot_cmdline) - 1] = 0; > > Please use strlcpy for this, which Dan recently added. We're trying to > cut down on the strncpys. > Fixed as well, same branch. -- You received this message because you are subscribed to the Google Groups "Akaros" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. For more options, visit https://groups.google.com/d/optout.
