I thought about this, and it seems reasonable so long as we never use max_vocres() == 0 as a proxy for in_multi_mode() (i.e. __procinfo.is_mcp) anywhere. We may have done this in old code somewhere. Did you do a survey of all uses of max_vcores()?
On Fri, Nov 13, 2015 at 12:37 PM, Barret Rhoden <[email protected]> wrote: > This popped up if you ran Akaros on a single core machine. In that case, > you'd > have 0 CG cores, which means the kernel gives you 0 vcores. However, SCPs > think they have one vcore. If a process runs at all, it needs to think it has > at least one vcore. > > Rebuild busybox. > > Signed-off-by: Barret Rhoden <[email protected]> > --- > user/parlib/include/vcore.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/user/parlib/include/vcore.h b/user/parlib/include/vcore.h > index 66b6b8134291..05e538ade7d5 100644 > --- a/user/parlib/include/vcore.h > +++ b/user/parlib/include/vcore.h > @@ -77,7 +77,7 @@ bool check_vcoreid(const char *str, uint32_t vcoreid); > /* Static inlines */ > static inline uint32_t max_vcores(void) > { > - return MIN(__procinfo.max_vcores, MAX_VCORES); > + return MAX(1, MIN(__procinfo.max_vcores, MAX_VCORES)); > } > > static inline uint32_t num_vcores(void) > -- > 2.6.0.rc2.230.g3dd15c0 > > -- > You received this message because you are subscribed to the Google Groups > "Akaros" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > For more options, visit https://groups.google.com/d/optout. -- ~Kevin -- You received this message because you are subscribed to the Google Groups "Akaros" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. For more options, visit https://groups.google.com/d/optout.
