With a post commit hook, the commit still occurs, but you get the warnings after the fact. With a pre-commit hook, it blocks the commit. There is also a commit-msg hook (which also blocks the commit), which I could run checkpatch over as well. However, if you ever do a git commit -n, then the commit-msg hook never runs. Seems like we need it in all thre places: pre-commit, commit-msg, post-commit.
On Fri, Nov 13, 2015 at 1:19 PM, Barret Rhoden <[email protected]> wrote: > On 2015-11-13 at 13:08 Kevin Klues <[email protected]> wrote: >> Looking more closely, this spelling error is in a commit message, not >> the code base. My workflow won't check for spelling errors in the >> commit message because it applies checkpatch as a pre-commit hook. > > commits 5 and 9. > > we talked about setting up a post-commit hook of some sort too. maybe > that would have caught it? > > no big deal either way. > > -- > You received this message because you are subscribed to the Google Groups > "Akaros" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > For more options, visit https://groups.google.com/d/optout. -- ~Kevin -- You received this message because you are subscribed to the Google Groups "Akaros" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. For more options, visit https://groups.google.com/d/optout.
