Thanks, I'll merge this all as is, to master at df0c3f4..bb3e85a (from, to]
You can see the entire diff with 'git diff' or at https://github.com/brho/akaros/compare/df0c3f4...bb3e85a Can you fix up a couple more things in later commits? The main problem I'm having is with the support tools, snc and kprof2perf. - there is no output from the build or install process from these. they silently build and (for snc) install to KFS. - I can't cd into their directories and run make. For things like tools/apps/busybox, you can cd into the directory and build it manually. Also, snc and kprof2perf leave blobs around that are tracked by git. I fixed this myself with the following patch: commit f622088961857a3153b8a3485d27e77dd3a77c4a Author: Barret Rhoden <[email protected]> Date: Wed Nov 18 10:17:42 2015 -0800 Ignore build output for snc and kprof2perf in git Any byproducts of building must be ignored by git. Signed-off-by: Barret Rhoden <[email protected]> diff --git a/tools/apps/snc/.gitignore b/tools/apps/snc/.gitignore new file mode 100644 index 0000000..29cf51c --- /dev/null +++ b/tools/apps/snc/.gitignore @@ -0,0 +1 @@ +snc diff --git a/tools/profile/kprof2perf/.gitignore b/tools/profile/kprof2perf/.gitignore new file mode 100644 index 0000000..eaa7b7f --- /dev/null +++ b/tools/profile/kprof2perf/.gitignore @@ -0,0 +1 @@ +kprof2perf-* which is now merged to master as well. On 2015-11-18 at 04:57 "'Davide Libenzi' via Akaros" <[email protected]> wrote: > Also added comment section to the head of the circular buffer header > file. > > > On Tue, Nov 17, 2015 at 4:53 PM, Davide Libenzi <[email protected]> > wrote: > > > Commits squashed. > > > > > > On Tue, Nov 17, 2015 at 3:20 PM, Barret Rhoden > > <[email protected]> wrote: > > > >> Hi - > >> > >> On 2015-11-13 at 19:54 "'Davide Libenzi' via Akaros" > >> <[email protected]> wrote: > >> > Coming to error(), should I always waserror() in my code, even > >> > if I have nothing to be undone? > >> > Because, that kinda defeats the exception-look-alike error model. > >> > >> I think no. You only need a waserror if you need to cleanup if a > >> function you call throws. If you have nothing to cleanup or if you > >> know that you don't call something that might throw, then you don't > >> need a waserror block. > >> > >> > circular_buffer_write already has the comments in its body, which > >> > describes the operation. > >> > Adding some more to the skip API. > >> > >> What I was getting at is that if someone looks at the code for > >> circular_buffer.h or circular_buffer.c, they won't know what it > >> does without looking into the code. This makes it more difficult > >> to use. > >> > >> Compare that to kern/include/trace.h, which has a bit of an > >> explanation and tells people how to use it. > >> > >> > I added two commits (WIP:PROFILER and WIP:KPROF) at the end of > >> > the stream, which did not squash in the proper place yet. > >> > Take a look. I really do not like the idea of having resources > >> > left allocated when the functionalities are not used. > >> > >> It seems okay. I understand the desire to free unused resources, > >> but the tradeoff is complexity and possible bugs. I don't know > >> that a small amount of RAM is worth that. But we'll see how this > >> works out. =) > >> > >> Anyway, once you squash those last two commits or do any other > >> stuff, let me know and I'll merge your latest. > >> > >> Barret > >> > >> > >> > >> > >> -- > >> You received this message because you are subscribed to the Google > >> Groups "Akaros" group. > >> To unsubscribe from this group and stop receiving emails from it, > >> send an email to [email protected]. > >> To post to this group, send email to [email protected]. > >> For more options, visit https://groups.google.com/d/optout. > >> > > > > > -- You received this message because you are subscribed to the Google Groups "Akaros" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. For more options, visit https://groups.google.com/d/optout.
