Hi - On 2015-11-12 at 12:34 Kevin Klues <[email protected]> wrote: > Updated with a new commit on top of the rest. > > The changes in this request can be viewed online at: > > https://github.com/brho/akaros/compare/1ed63f9...152eb22 > > The following changes since commit > 1ed63f9f8e25820f7eb217727d4ee88efe827d41: > > Migrated Akaros code to use pragma once (XCC) (2015-11-11 11:37:59 > -0500) > > are available in the git repository at: > > [email protected]:klueska/akaros refactor-scheduler
Looks good overall. I had originally thought that people might replace schedule.c with their changes. For example, someone might want to change the whole double-list approach of primary_mcps and secondary_mcps, change how/when the ksched deals with requests, etc. But given the way things are and how schedule.c has grown, splitting out the alloc strategy sounds good. Two minor things: 1) Most of these commits are moving things around. The new files have their own copyright header. Since they (at this point) heavily consist of code from another file, the original header from e.g. schedule.c should be on those new files. 2) > From 504f55684d46d60f8682dc111dafa1aa6655787a Mon Sep 17 00:00:00 2001 > From: Kevin Klues <[email protected]> > Date: Mon, 5 Oct 2015 15:27:42 -0700 > Subject: Kconfig option to change core allocation policy > kern/src/{corealloc.c => fcfs_corealloc.c} | 0 Any reason for TYPE_corealloc.c instead of corealloc_TYPE.c? The latter will sort more nicely in kern/src. Barret -- You received this message because you are subscribed to the Google Groups "Akaros" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. For more options, visit https://groups.google.com/d/optout.
