On 2015-11-24 at 08:21 "'Davide Libenzi' via Akaros"
<[email protected]> wrote:
> > void completion_wait(struct completion *comp)
> > {
> > int8_t state;
> >
> > cv_lock_irqsave(&comp->cv, &state);
> > if (comp->count > 0) {
> > cv_wait_and_unlock(&comp->cv);
> > enable_irqsave(&state);
> > } else {
> > cv_unlock_irqsave(&comp->cv, &state);
> > }
> > }
> >
My fault, state needs to be initialized:
int8_t state = 0;
I can touch that up if you'd like.
> > I think we were missing get_bit, but we have __set_bit and
> > __clear_bit (the __ are the non-atomic versions).
> >
>
> Oh, I missed the *arch* bitops.h file 😀
> Undoing the mem_ ... adding get_bit()
Again, my fault, I missed test_bit() in arch bitops.h. It's a macro,
which might be why I missed it. Not sure. =P
I can touch that up too (replace get_bit with test_bit).
One other minor thing is that 3f21a3870 "Added CPU set data structure"
adds both core_set.h and cpu_set.h. I can also touch that up if you'd
like.
Let me know if you want to update the branch or if you want me to do
the touchups.
Thanks,
Barret
--
You received this message because you are subscribed to the Google Groups
"Akaros" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
For more options, visit https://groups.google.com/d/optout.
