I'd actually prefer that this be controlled by a command line option. Each config variable multiplies the number of possible build configurations by 2 and in some sense add more complications should we ever wish to audit the code.
The command line option lets us ensure all the code still compiles. If we have a problem we can test the legacy USB path control without a rebuild. The path this controls -- early startup -- happens once and testing a variable is a trivial one-time cost. Just my take. ron On Wed, Nov 25, 2015 at 6:48 AM Barret Rhoden <[email protected]> wrote: > On 2015-11-24 at 14:40 Barret Rhoden <[email protected]> wrote: > > If you want to use a USB keyboard, you'll need to enable this CONFIG. > > It is disabled by default, since we usually use serial access and it > > is a source of interference. Sometimes you want a keyboard for > > debugging. > > Thanks, merged to master at 46f5b5aaacbc..22e5a17da08e (from, to] > > You can see the entire diff with 'git diff' or at > https://github.com/brho/akaros/compare/46f5b5aaacbc...22e5a17da08e > > -- > You received this message because you are subscribed to the Google Groups > "Akaros" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Akaros" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. For more options, visit https://groups.google.com/d/optout.
