On 2015-11-28 at 7:19 'Davide Libenzi' via Akaros wrote: > These interfaces though, are not exposed to userspace, so I will have > to move them into a dedicated ros/ file, I guess?
That's fine. In the long term, I'd like to make these interfaces protobufs, such that the .proto is in ros/, and both the user and the kernel have their conv_ functions generated. But for now, we can have the gets and puts be in an ros/ file. > Also, any reason why those could not be static inline (and turned into > something like get_u16, put_u16, ...)? > Are they something coming from imported code, which we do not want to > change name? They do come from the original plan 9 code, but we can still change them to be more descriptive (and inlines). One thing though is that we do want to keep the Plan 9 implementations of those functions that do not use ifdefs: http://commandcenter.blogspot.com/2012/04/byte-order-fallacy.html (at least I think we do). Barret -- You received this message because you are subscribed to the Google Groups "Akaros" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. For more options, visit https://groups.google.com/d/optout.
