On 2015-12-01 at 6:29 'Davide Libenzi' via Akaros wrote: > On Tue Dec 1, 2015 at 6:23 AM, barret rhoden <[email protected]> > wrote: > > > On 2015-11-30 at 16:48 'Davide Libenzi' via Akaros wrote: > > > Would be nice to use const, for pointers which are. > > > Example, the path and args/env of sys_proc_create. > > > > In general, that might be nice. If we want to modify the variables > > later, we can always change it back. > > > > It probably doesn't matter for any syscall, since they all are > > called 'blindly' by the dispatch table in syscall(). > > > > The externally visible parlib API has char* as parameter. This is what > caught my attention, as my arguments where const char*, and > compilation nailed me.
Ah, gotcha. Feel free to send a patch changing those to const (both in the kernel for sys_proc_create() as well as for parlib's wrapper). Thanks. -- You received this message because you are subscribed to the Google Groups "Akaros" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. For more options, visit https://groups.google.com/d/optout.
