On 2015-12-03 at 05:29 "'Davide Libenzi' via Akaros" <[email protected]> wrote: > Whoops. All my code so far used TABs for indenting function args 😐 > Another thing I noticed, is that I had to special case the switch/case > alignment to this: > > switch (...) > case FOO: > code... > > From the default: > > switch (...) > case FOO: > code... > > But I noticed Barrett latest code (the var one?) used the latter.
Yeah, for whatever reason, we went with the extra indent for the case back in the day. I noticed Linux and a few others were using the no indent (latter style) and figured I'd use that. Feel free to use whichever you'd like. All in all, diverging from the Linux style was a mistake. We might have come up with something better (I personally liked 4-space tabs, for instance), but it's not worth the hassle, especially when there are a lot of tools out there that are made to work with the Linux style (e.g. vim plugins or whatever). On occasion, I'm tempted to just switch over completely to the Linux style, run checkpatch on the entire code base, and fix it all in one fell swoop. The downside is that it'd mess up the git history a bit, such that git blame wouldn't be as useful since a bunch of lines are getting changed purely for formatting reasons. Barret -- You received this message because you are subscribed to the Google Groups "Akaros" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. For more options, visit https://groups.google.com/d/optout.
