That was done yesterday. Branch is ready. I also changed the open coded offset of field, to the offsetof() macro in common.
On Wed, Dec 9, 2015 at 9:18 AM, Barret Rhoden <[email protected]> wrote: > On 2015-12-08 at 16:49 "'Davide Libenzi' via Akaros" > <[email protected]> wrote: > > I did a small change to the script. If you are already done, or > > started, doesn't matter, as I can apply the diff later on. > > I haven't started yet, so feel free to update this branch. > > Barret > > > > > > > On Fri, Dec 4, 2015 at 5:17 PM, Davide Libenzi <[email protected]> > > wrote: > > > > > Here is the proper code review for what posted previously. > > > It is missing the proper hooking into .S files. I can do that once > > > Barrett changes touching those are in. > > > > > > https://github.com/brho/akaros/compare/master...dlibenzi:asm_offsets > > > > > > The following changes since commit > > > 2fa42319139e4cc5ca853546363f84443d0ead00: > > > > > > Rename 'reallocarray' to 'kreallocarray'. (2015-11-25 18:02:04 > > > -0500) > > > > > > are available in the git repository at: > > > > > > [email protected]:dlibenzi/akaros asm_offsets > > > > > > for you to fetch changes up to > > > 9d4814ec131f82e674be991eb2655755c09cfa24: > > > > > > Added ability to generate C structure offset definitions for asm > > > files (2015-12-04 17:10:49 -0800) > > > > > > ---------------------------------------------------------------- > > > Davide Libenzi (1): > > > Added ability to generate C structure offset definitions for > > > asm files > > > > > > Makefile | 12 +++++- > > > kern/include/.gitignore | 1 + > > > kern/include/gen_offsets.h | 9 +++++ > > > kern/src/asm-offsets.c | 59 ++++++++++++++++++++++++++++++ > > > scripts/gen_offsets | 91 > > > ++++++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 171 > > > insertions(+), 1 deletion(-) create mode 100644 > > > kern/include/.gitignore create mode 100644 > > > kern/include/gen_offsets.h create mode 100644 kern/src/asm-offsets.c > > > create mode 100755 scripts/gen_offsets > > > > > > > > > > > > > -- > You received this message because you are subscribed to the Google Groups > "Akaros" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Akaros" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. For more options, visit https://groups.google.com/d/optout.
