On 2015-12-08 at 23:50 ron minnich <[email protected]> wrote:
> I found the comment placement a little confusing:
>   /* If you use pcpui again, reread it, since you might have migrated
> */
> + disable_irq();
>   proc_restartcore();
>  }

I touched up that comment/commit:

@@ -638,9 +642,10 @@ void sysenter_callwrapper(struct syscall *sysc, unsigned 
long count,
         * mandatory (we had immediate KMSGs that would muck with cur_ctx).  
Now it
         * should only help for sanity/debugging. */
        enable_irq();
-       /* Set up and run the async calls */
+       /* Set up and run the async calls.  This may block, and we could 
migrate to
+        * another core.  If you use pcpui again, you need to reread it. */
        prep_syscalls(current, sysc, count);
-       /* If you use pcpui again, reread it, since you might have migrated */
+       disable_irq();
        proc_restartcore();
 }
 
I also removed the commit: 2b1528ae41ee ("Do not use the return value
of switch_to"), which was breaking test_uaccess, and replaced it with
a1c75135e810 ("Use a temp process for test_uaccess")

Barret

-- 
You received this message because you are subscribed to the Google Groups 
"Akaros" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to