Should we comment out the openat() test? Or, invert the assert condition?
On Tue, Dec 15, 2015 at 6:51 AM, Davide Libenzi <[email protected]> wrote: > For the uaccess one, /me looks at Barrett ☺ > > > https://github.com/brho/akaros/commit/a1c75135e810a7b645a398e6fc8da16bf62af041 > > > On Tue, Dec 15, 2015 at 6:43 AM, Kevin Klues <[email protected]> wrote: > >> On Tue, Dec 15, 2015 at 6:35 AM, 'Davide Libenzi' via Akaros >> <[email protected]> wrote: >> > One is this, not sure how long it was failing: >> > >> > <-- BEGIN_USERSPACE_FILE POSIX_TESTS --> >> > FAILED [test_openat](0.000018s) Assertion failure in >> > test_openat() at file-posix.c:26: ffd >= 0 >> > <-- END_USERSPACE_FILE POSIX_TESTS --> >> >> We talked about this a little here: >> >> https://groups.google.com/forum/#!searchin/akaros/Kernel$20tests/akaros/o9UWE6Tywo0/X3Zw9cUjAQAJ >> >> Basically, it is currently "supposed" to fail because we don't yet >> support open_at in the VFS. Once this is fixed (or bypassed), we will >> be able to pass the test. >> >> > >> > >> > The other one is in uaccess test. After munamp() the copy should fail: >> > >> > FAILED [test_uaccess](0.000185s) Assertion failure in >> test_uaccess() at >> > kern/src/ktest/pb_ktests.c:2234: Copy to user (u8) to not mapped address >> > should fail >> > >> > This was not failing before. This is the code: >> > >> > munmap(tmp, (uintptr_t) addr, mmap_size); >> > >> > KT_ASSERT_M("Copy to user (u8) to not mapped address should fail", >> > copy_to_user(addr, buf, 1) == -EFAULT); >> > >> > Basically, that test should fail, but it does not. >> > Need to investigate why, as the test was not failing before. >> > >> > -- >> > You received this message because you are subscribed to the Google >> Groups >> > "Akaros" group. >> > To unsubscribe from this group and stop receiving emails from it, send >> an >> > email to [email protected]. >> > To post to this group, send email to [email protected]. >> > For more options, visit https://groups.google.com/d/optout. >> >> >> >> -- >> ~Kevin >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Akaros" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To post to this group, send email to [email protected]. >> For more options, visit https://groups.google.com/d/optout. >> > > -- You received this message because you are subscribed to the Google Groups "Akaros" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. For more options, visit https://groups.google.com/d/optout.
