Currently all the calls to readstr marshal back the return value, so using copy to user should be fine.
https://github.com/dlibenzi/akaros/commit/1b5fbe1220b9ea96067fb0d696bd8493b244f56f On Tue, Dec 15, 2015 at 8:07 AM, Barret Rhoden <[email protected]> wrote: > On 2015-12-15 at 05:42 "'Davide Libenzi' via Akaros" > <[email protected]> wrote: > > Fixing that. The API AFAICS should only be used to copy to user, so I > > will change memmove() to the proper copy to user API. > > please hold off on this. if those calls are protected by waserror, > then the memmoves will be safe (eventually). > > this goes back to our old discussion about how to handle kernel page > faults. part of the issue is that the kernel is also a client of some > servers, and the copy_to_user will fail in those cases. > > barret > > -- > You received this message because you are subscribed to the Google Groups > "Akaros" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Akaros" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. For more options, visit https://groups.google.com/d/optout.
