Hold on on this review, using the readstr, I have found another issue. Also, I am adding a numeric version and name as well:
VERSION = 0 PATCHLEVEL = 1 SUBLEVEL = 0 EXTRAVERSION = VERNAME = Nanwan KERNELVERSION = $(VERSION)$(if $(PATCHLEVEL),.$(PATCHLEVEL)$(if $(SUBLEVEL),.$(SUBLEVEL)))$(EXTRAVERSION) Question about that big line. It is exceeding 80 chars, but if I break it with \, a space is added in any case to the resulting string. Any idea? On Tue, Dec 15, 2015 at 8:12 AM, Davide Libenzi <[email protected]> wrote: > You can drop that commit if you like. It is not used anymore. > I thought it useful to have it. > If that sigscan API does it, that's OK. It's name is not exactly telling > it though ☺ > > > On Tue, Dec 15, 2015 at 8:10 AM, Barret Rhoden <[email protected]> > wrote: > >> On 2015-12-14 at 20:28 "'Davide Libenzi' via Akaros" >> <[email protected]> wrote: >> > Added memstr() API to allow to search strings in memory >> >> i haven't pulled the patchset down to look closely yet, but I think we >> already have something for memstr() >> >> void *sigscan(uint8_t *address, int length, char *signature); >> >> in k/s/string.c >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Akaros" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To post to this group, send email to [email protected]. >> For more options, visit https://groups.google.com/d/optout. >> > > -- You received this message because you are subscribed to the Google Groups "Akaros" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. For more options, visit https://groups.google.com/d/optout.
