Hi - On 2016-01-11 at 17:09 Geoff Collyer <[email protected]> wrote: > …t Plan 9. > > You can view, comment on, or merge this pull request online at: > > https://github.com/brho/akaros/pull/26 > > -- Commit Summary -- > > * Fix ipv6 icmp bugs in locking and freeing in icmphostunr() per > current Plan 9. > > -- File Changes -- > > M kern/src/net/icmp6.c (18) > > -- Patch Links -- > > https://github.com/brho/akaros/pull/26.patch > https://github.com/brho/akaros/pull/26.diff > > --- > Reply to this email directly or view it on GitHub: > https://github.com/brho/akaros/pull/26
The patch content looks good. As a couple of administrative things: - Could you commit with -s? That applies your "Signed-off-by" tag to the commit. That sign-off signifies that you agree to the Developer Certificate of Origin (found at Documentation/Developer_Certificate_of_Origin or at http://developercertificate.org/). You can fix this current one with a git commit --amend -s - For future commits, please also tell me the branch and remote. It's not a big deal for single commits, but if you have a long patch set, it'll make my life easier. The output of "git request-pull" will do the trick. Thanks, Barret -- You received this message because you are subscribed to the Google Groups "Akaros" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. For more options, visit https://groups.google.com/d/optout.
