Hi - On Friday, January 22, 2016 at 1:56:24 PM UTC-5, rminnich wrote: > > The following changes since commit > 6ae8195b99f28d2f2735dcde2a723a4bde3142ef: > > Add taps for pipes. (2016-01-14 16:04:46 -0500) > > are available in the git repository at: > > [email protected]:rminnich/akaros fixerror > > for you to fetch changes up to > 337053a79cf7e689e0f01b67d2ab37d8eedc6db6:
Thanks for this. Removing those error(x, NULL)s was on my TODO list. The __LINE__ macro reminds me of this lovely hack: https://lwn.net/Articles/614446/ Next up, we can yank out the code that even allows null errstrings, and from now on, require that people not have null errstrs. As far as the macro goes, the existing __LINE__ trick doesn't work (as you mentioned in the commit message). It just literally writes "__LINE__" in the output: e.g. Invalid argument, This space in kern/src/syscall.c@__LINE__ needs filling in. However, this works: #define ERROR_FIXME "This space in %s@%d needs filling in.", __FILE__, __LINE__ e.g. Invalid argument, This space in kern/src/syscall.c@371 needs filling in. I touched that up. Merged to master at 1be7805168b9..3d2b33e90036 (from, to] You can see the entire diff with 'git diff' or at https://github.com/brho/akaros/compare/1be7805168b9...3d2b33e90036 Barret -- You received this message because you are subscribed to the Google Groups "Akaros" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. For more options, visit https://groups.google.com/d/optout.
