Your comments all make sense. I think I'd really like to try going forward with clang but it's no rush. I tried it just for amusement value last night and was kind of blown away at how good a job it did -- I don't recall it being that good before. I feel like the "make C look good" part of my brain is due for retirement.
I was also pretty impressed with the whole Go experience. I really don't miss code formatting arguments any more :-) thanks ron On Fri, Jan 29, 2016 at 9:56 AM 'Davide Libenzi' via Akaros < [email protected]> wrote: > The reason I mentioned reformatting first, is that if A=good and > B=A+patch=good, implies patch=good. > On Jan 29, 2016 09:52, "barret rhoden" <[email protected]> wrote: > >> On 2016-01-29 at 9:45 'Davide Libenzi' via Akaros wrote: >> > If clang format uses the compiler front end core libraries to parse >> > and reformat (like it seems), than it is clearly better than a Perl >> > script with regexes. >> > But with checkpatch you can check your very own commit diff, while >> > clang format would bark on the whole file(s). >> > So to use that, you would need to apply clang format to the whole code >> > base, to avoid your one liner patch to be barked upon, for unrelated >> > format failures in the touched source files. >> >> Verifying individual patches is the main use I have for checkpatch, so >> whatever we come up with needs to support that. >> >> Having a precommit hook is nice for individual developers, but I also >> need to verify on my end that the patches are good. >> >> Perhaps the clang-reformatter that you used could replace our >> scripts/lindent.sh. That one was intended to attempt to fix an entire >> file, but it tended to get a bunch of things wrong. If the >> clang-formatter that you used will do the trick for the big file, we >> can use that in the common sequence of code importing: >> 1. import >> 2. spatch >> 3. lindent -> clang >> >> Also, in general, does your final patch after that clang reformat pass >> most of checkpatch's tests? If not, that sounds like something is >> wrong. >> >> Barret >> >> > > BasedOnStyle: LLVM >> > > IndentWidth: 8 >> >> p.s. 8 -> 4. >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Akaros" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To post to this group, send email to [email protected]. >> For more options, visit https://groups.google.com/d/optout. >> > -- > You received this message because you are subscribed to the Google Groups > "Akaros" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Akaros" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. For more options, visit https://groups.google.com/d/optout.
