On Sun, Jan 31, 2016 at 12:01 PM, Barret Rhoden <[email protected]> wrote:
> On 2016-01-25 at 18:47 Dan Cross <[email protected]> wrote: > > The following changes since commit > > 915eac00a7e0f578f9e921af2b205b6efa3739b5: > > > > Slices: A growable list of pointers. (2016-01-25 11:02:20 -0500) > > > > are available in the git repository at: > > > > [email protected]:dancrossnyc/akaros.git ether82563 > > I'm a little concerned about things that were done to the old driver > (fixes and changes for Akaros) that didn't get brought over for the new > one. Over time, this method of re-porting a driver will probably turn > into a mess. > Indeed. For this change, I went through the driver history and looked at each commit and brought over what I thought to be relevant changes. Can you double-check with a git log that you didn't miss anything? I > found two commits at least: > > ffa08811d0d6 ("82536: removes receive buffer pools") > I just looked at this again. The old receive buffer pools code that the commit you referred to changed was substantially different than what was in the newly ported driver; it wasn't clear to me that this was a problem and I didn't want to diverge too far from the Plan 9 driver. and > > 1795dce1b1e6 ("82563/i350: Fixes off-by-one issue") > These changes were brought in, though in a different way than in this change. In the above referenced commits, this was effected by setting a temporary to the value of a structure member minus 1. However, that structure member did not exist in the (new) Plan 9 driver, was only set to a constant in the old driver anyway; I implemented the effect of the change in the above mentioned commit by changing the loop index to -1 the constant value. In other words, the effect of the change was brought in, but done in a way that more closely matched the new driver's extant structure. The latter one probably fixes the underruns you were seeing on > hardware. > It's possible that I missed a place, but that change was brought in. - Dan C. Thanks, > > Barret > > -- > You received this message because you are subscribed to the Google Groups > "Akaros" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Akaros" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. For more options, visit https://groups.google.com/d/optout.
