I was a little surprised by the braces one. A lack of braces around if statement bodies always felt a bit fragile to me. And there was the whole Apple "goto fail" thing a couple years ago... But if that's a hard and fast rule for us then I'll roll with it.
I just matched the style of the existing aligns/other attributes in the codebase, so I figure it's ok to ignore those warnings. I'll switch the newlines to ; for the symbols. On Tuesday, February 23, 2016 at 12:54:34 PM UTC-8, Barret Rhoden wrote: > > On 2016-02-23 at 10:47 Michael Taufen <[email protected] <javascript:>> > wrote: > > The following changes since commit > > e156d6fde7e58b7c958371a91d18d3d8e60fb643: > > > > Add page reference counting to mm hooks. (2016-02-23 11:15:56 -0500) > > > > are available in the git repository at: > > > > [email protected]:mtaufen/akaros.git xsave-cleanup-final > > I haven't looked at the code yet, but checkpatch has a few complaints. > > The braces one looks legit. > > We don't use __align, so that is probably a Linux-specific warning (I > think). > > For inline asm, I usually just do something like: > > "addq $0xa0, %%rsp; " > "popq %%rsp; " > "1: " > > instead of worrying about the '\n's. > > I'll check out the actual code soon. =) > > Barret > -- You received this message because you are subscribed to the Google Groups "Akaros" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. For more options, visit https://groups.google.com/d/optout.
