This was limiting us to 64 vcores. Instead of cranking the number up, I opted to just remove the #define completely. We should be able to figure these things out dynamically.
Right now MAX_NUM_CORES is 256 for x86. That was due to the old xAPIC. One of these days we'll actually want to run on a large-scale SMP machine and will want to increase that. And then we'll also start worrying about the size of things that grow O(MAX_NUM_CORES) for every process, e.g. procdata. Signed-off-by: Barret Rhoden <[email protected]> --- user/parlib/include/parlib/vcore.h | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/user/parlib/include/parlib/vcore.h b/user/parlib/include/parlib/vcore.h index a965591b04f7..02bbab5f79c5 100644 --- a/user/parlib/include/parlib/vcore.h +++ b/user/parlib/include/parlib/vcore.h @@ -21,9 +21,6 @@ extern void exit (int __status) __THROW __attribute__ ((__noreturn__)); #define exit(status) _exit(status) /*****************************************************************************/ -#define LOG2_MAX_VCORES 6 -#define MAX_VCORES (1 << LOG2_MAX_VCORES) - #define TRANSITION_STACK_PAGES 2 #define TRANSITION_STACK_SIZE (TRANSITION_STACK_PAGES*PGSIZE) @@ -78,7 +75,7 @@ void print_user_context(struct user_context *ctx); /* Static inlines */ static inline uint32_t max_vcores(void) { - return MAX(1, MIN(__procinfo.max_vcores, MAX_VCORES)); + return MAX(1, __procinfo.max_vcores); } static inline uint32_t num_vcores(void) -- 2.7.0.rc3.207.g0ac5344 -- You received this message because you are subscribed to the Google Groups "Akaros" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. For more options, visit https://groups.google.com/d/optout.
