Sure. give me a few minutes.... On Wed, Mar 9, 2016 at 11:15 AM, Barret Rhoden <[email protected]> wrote:
> Hi - > > Thanks for the cleanup. Comments below. > > On 2016-03-09 at 11:02 Dan Cross <[email protected]> wrote: > > diff --git a/kern/src/net/icmp6.c b/kern/src/net/icmp6.c > > @@ -347,10 +336,9 @@ static void icmpctl6(struct conv *c, char > > **argv, int argc) { > > Icmpcb6 *icb = (Icmpcb6*)c->ptcl; > > > > - if ((argc == 1) && strcmp(argv[0], "headers") == 0) > > - icb->headers = 6; > > - else > > - error(EINVAL, "unknown command to %s", __func__); > > + if ((argc != 1) || strcmp(argv[0], "headers") != 0) > > + error(EINVAL, "unknown command to icmpctl6"); > > + icb->headers = 6; > > } > > this function was the way it was so that we could easily add more ctl > messages. see e.g. udpctl. > > > > static void goticmpkt6(struct Proto *icmp, struct block *bp, int > > muxkey) @@ -396,14 +384,16 @@ static struct block > > *mkechoreply6(struct block *bp) > > /* > > * sends out an ICMPv6 neighbor solicitation > > - * suni == SRC_UNSPEC or SRC_UNI, > > + * suni == SRC_UNSPEC or SRC_UNI, > > * tuni == TARG_MULTI => multicast for address resolution, > > * and tuni == TARG_UNI => neighbor reachability. > > */ > > > > extern void > > -icmpns(struct Fs *f, uint8_t * src, int suni, uint8_t * targ, int > > tuni, > > - uint8_t * mac) > > +icmpns(struct Fs *f, > > + uint8_t *src, int suni, > > + uint8_t *targ, int tuni, > > + uint8_t *mac) > > Since you're changing these function decs, you might as well also > remove the extern and put the void on the same line as the function > name. (for this and all the other funcs you're touching). > > Barret > > -- > You received this message because you are subscribed to the Google Groups > "Akaros" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Akaros" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. For more options, visit https://groups.google.com/d/optout.
