On Fri, Mar 11, 2016 at 1:25 PM, Barret Rhoden <[email protected]> wrote:
> On 2016-03-11 at 13:10 "'Kanoj Sarcar' via Akaros" > <[email protected]> wrote: > > I quickly browsed the patchset, technically looks ok. When you are > > ready, please push them, and I will try out my tests. > > If you "git checkout -b temp origin/pat" you should be able to build and > test it out. Or I could just push it. > Yes, just push it. > > > One issue I have is that the behavior is subtly changed vs Linux. In > > the future, if we port a Linux driver that uses UC- using > > Linux's well known pgprot_noncached() and MTRR api's to overwrite to > > WC, it will take just a little more effort (if we notice > > the subtle difference) to make it work as intended on Akaros > > I'd like to avoid using the MTRRs if possible. If someone wants a WC > region, I'd rather map it our way. But maybe that's unavoidable. > > Regardless, one change I could make to my patchset would be to change > the UC to UC- in our PAT setup for PAT 3. That would mean we don't have > UC anywhere, but since we avoid using MTRRs (for the most part), then > UC- has the same effect as UC. In that case, pgprot_noncached would > have the same UC- semantics as on Linux. > > How does that sound? > If you are comfortable with changing existing Akaros usage of UC to UC-, I would prefer this. > > Barret > > -- > You received this message because you are subscribed to the Google Groups > "Akaros" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- Thanks, Kanoj -- You received this message because you are subscribed to the Google Groups "Akaros" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. For more options, visit https://groups.google.com/d/optout.
