On 2016-05-10 at 11:13 Dan Cross <[email protected]> wrote:
> On Tue, May 10, 2016 at 11:02 AM, Barret Rhoden <[email protected]>
> wrote:
>
> > Hi -
> >
> > On 2016-05-10 at 10:40 Dan Cross <[email protected]> wrote:
> > > This is hokey in the way we use krefs, due to racey code
> > > inherited from Plan 9. But it works well enough now that
> > > ipconfig runs and gets us a DHCP lease.
> > >
> > > Change-Id: I966a41f90a2d129eb9f07d9a7993fda990af1dbb
> > > Google-Bug-Id: 28667887
> >
> > Do you all need this metadata in the commit log? I don't see any
> > Google-Bug-Id's in upstream Linux's commit log...
> >
>
> I thought I removed them. :-/
I can remove them at merge time if you'd like for this patch.
> > /*
> > > + * TODO: Change this to a proper release.
> > > + * At the moment, this is difficult since link removal
> > > + * requires access to more than just the kref/struct Iplink.
> > > + * E.g., the self and interface pointers.
> > > + */
> > > +static void link_release(struct kref *kref)
> > > +{
> > > + (void)kref;
> >
> > What's this doing? If the function does nothing, we can just have no
> > statements.
>
>
> This is how C11 spells, "explicitly ignore this parameter, and do not issue
> a warning if it's unused."
We don't build with -Wunused-parameter, so it's not needed. That being said,
I'm ok if you want to keep it. (possibly averting a compiler flags holy war).
Barret
--
You received this message because you are subscribed to the Google Groups
"Akaros" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
For more options, visit https://groups.google.com/d/optout.
