What style guide do you guys use? Is there one? On Wed, May 11, 2016, 15:09 barret rhoden <[email protected]> wrote:
> Hi - > > > On 2016-05-11 at 13:33 'Christopher Koch' via Akaros wrote: > > The following changes since commit > > 9b980217a606d71fd787cc4e05f8acc1d8feddea: > > > > VMM: Make new virtio implementation work with new vmm 2LS > > (2016-05-11 09:52:00 -0700) > > > > are available in the git repository at: > > > > [email protected]:hugelgupf/akaros.git HEAD > > > > for you to fetch changes up to > > e4c95a2eb42b8d7de1d9f9e96281474c2474d975: > > > Nice check, and hope it wasn't too nasty of a bug that it was hiding. =) > > A couple minor things: > > > From e4c95a2eb42b8d7de1d9f9e96281474c2474d975 Mon Sep 17 00:00:00 2001 > > From: Christopher Koch <[email protected]> > > Date: Wed, 11 May 2016 12:39:00 -0700 > > Subject: Check that bus freq is not zero > > > > Change-Id: Ib1e8986c4d1a41b87d854d9b47c301bd585f89ca > > --- > > We need a Signed-off-by line. In general, you can get this from > > $ git commit -s > > For this one commit, you can amend it: > > $ git commit -s --amend > > > kern/arch/x86/time.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/kern/arch/x86/time.c b/kern/arch/x86/time.c > > index fed0b73040ee..e93569c0e9af 100644 > > --- a/kern/arch/x86/time.c > > +++ b/kern/arch/x86/time.c > > @@ -39,6 +39,7 @@ void timer_init(void){ > > timercount[1] = apicrget(MSR_LAPIC_CURRENT_COUNT); > > __proc_global_info.bus_freq = (timercount[0] - timercount[1]) > > * LAPIC_TIMER_DIVISOR_VAL; > > + assert(__proc_global_info.bus_freq); > > This line needs to be indented with tabs, not spaces. Checkpatch won't > always catch stuff like that. (Tabstop is 4 btw). > > > Thanks, > > Barret > > -- > You received this message because you are subscribed to the Google Groups > "Akaros" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- Christopher Koch | Software Engineer | [email protected] | 650-214-3546 -- You received this message because you are subscribed to the Google Groups "Akaros" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. For more options, visit https://groups.google.com/d/optout.
