On 2016-05-31 at 17:20 Dan Cross <[email protected]> wrote: > These are defined in third_party code, but in code that we control, > replace these with calls to our COUNT_OF macro.
Thanks. To some extent, we're living on borrowed time with ros/common.h and similar headers. It's a nice idea to have convenient things for userspace, like ARRAY_SIZE, but we run into collisions with other projects who had the same idea who unfortunately didn't use an ifndef. The end result is that every project ends up defining these things. If we ever run into someone using COUNT_OF, then we can revisit this, like we do with any other header collisions. Merged to master at 63c267a4a23f..c658bc5e143c (from, to] You can see the entire diff with 'git diff' or at https://github.com/brho/akaros/compare/63c267a4a23f...c658bc5e143c Barret -- You received this message because you are subscribed to the Google Groups "Akaros" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. For more options, visit https://groups.google.com/d/optout.
