LGTM. Why are you commenting out the stuff in checkpatch instead of just deleting it? Git history can show it if we really need it again.
On Mon, Jun 20, 2016 at 10:47 AM Dan Cross <[email protected]> wrote: > LGTM > > On Mon, Jun 20, 2016 at 1:41 PM, Barret Rhoden <[email protected]> > wrote: > >> Hi - >> >> Here are a few patches of minor things I've been meaning to fix. >> >> Barret >> >> >> The following changes since commit >> 89c4e6ce669c5a063b65f6405c3fbcf02ff50b56: >> >> VMM: Dynamically retrieve the interrupt vector for a virtio device. >> (2016-06-20 10:29:36 -0400) >> >> are available in the git repository at: >> >> [email protected]:brho/akaros.git piddles >> >> for you to fetch changes up to 4f49a42d4271248aa9973be5b223fbf901ddb1cc: >> >> Have checkpatch ignore Gerrit change-ids (2016-06-20 13:37:02 -0400) >> >> ---------------------------------------------------------------- >> View this online at: >> https://github.com/brho/akaros/compare/89c4e6ce669c...4f49a42d4271 >> >> ---------------------------------------------------------------- >> Barret Rhoden (5): >> Update scripts/git/mbox-to-patches.sh >> Gracefully fail ipconfig when DHCP times out >> Rename event_bits.h -> bits/event.h (XCC) >> Update rules for contributing external code >> Have checkpatch ignore Gerrit change-ids >> >> Documentation/Contributing.md | 8 ++-- >> kern/include/ros/{event_bits.h => bits/event.h} | 0 >> kern/include/ros/ceq.h | 2 +- >> kern/include/ros/evbitmap.h | 2 +- >> kern/include/ros/event.h | 2 +- >> kern/include/ros/ucq.h | 2 +- >> scripts/checkpatch.pl | 11 +++-- >> scripts/git/mbox-to-patches.sh | 43 +++++++---------- >> tools/apps/ipconfig/main.c | 61 >> +++++++++++-------------- >> 9 files changed, 57 insertions(+), 74 deletions(-) >> rename kern/include/ros/{event_bits.h => bits/event.h} (100%) >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Akaros" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To post to this group, send email to [email protected]. >> For more options, visit https://groups.google.com/d/optout. >> > > -- > You received this message because you are subscribed to the Google Groups > "Akaros" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- Christopher Koch | Software Engineer | [email protected] | 650-214-3546 -- You received this message because you are subscribed to the Google Groups "Akaros" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. For more options, visit https://groups.google.com/d/optout.
