On line 116 of user/parlib/dtls.c, could you ever encounter a situation
where you have to call dtls_cache_init() as is done in
__allocate_dtls_key() ?
On line 199, what purpose does the assignment of NULL to v->dtls serve? Is
the idea that the dtor could inadvertently reference it?
set/get_dtls() both look to the uninitiated like they could be racy; would
it make sense to add a comment of some kind explaining how they are not
(e.g., because they are inherently thread-local: the TL in DTLS).
On lines 13-15 of user/parlib/include/parlib/dtls.h, __GNUC__ is sadly
defined by several compilers (GCC, clang, and the Intel C compiler). Is it
really that we care about GCC, or is it just that we care about being
GCC-compatible? (I assume the latter.)
On line 20 of user/utest/dtls.c I think it would be slightly more
informative to say, "Expected NULL ..." instead of "expected 0" to
accentuate that it's looking at a pointer, not an int.
On line 33, it may be nice to get the value before dtls_destroy() to
validate that it WAS set before resetting.
On lines 64-65, what's the expected behavior of setting twice? Last one
wins? It would be nice if the test asserted that.
On line 74 how does one pronounce "f00"? :-D
On lines 77-85, it's unclear to me what the expected behavior of setting
from a dtor is; could you add an assert to probe that?
On line 96 perhaps use ARRAY_SIZE() or COUNT_OF() or whatever we're calling
it now?
On line 104; what's the behavior when there are no arguments so the
program, so that main() gets argc == 1 and argv == {"testname", NULL} =>
whitelist == a pointer a NULL pointer?
On Thu, Aug 4, 2016 at 1:29 PM, Barret Rhoden <[email protected]> wrote:
> Hi -
>
> The following changes since commit 0a2ea83cece3b6cb2dfc3986da19a8
> 61162fd335:
>
> Fix wonky tail queue swap in condition variables code. (2016-08-03
> 15:22:32 -0700)
>
> are available in the git repository at:
>
> [email protected]:brho/akaros.git dtls
>
> for you to fetch changes up to 56f5c580c121a4b46e55837ce4bf058a78e07e9b:
>
> Fix multiple setting in DTLS (2016-08-04 10:05:34 -0700)
>
> ----------------------------------------------------------------
> View this online at:
> https://github.com/brho/akaros/compare/0a2ea83cece3...56f5c580c121
>
> ----------------------------------------------------------------
> Barret Rhoden (4):
> Fix the license on certain Parlib files
> Add a couple features to .clang_format
> Reformat DTLS
> Fix multiple setting in DTLS
>
> .clang-format | 3 +-
> user/parlib/dtls.c | 309 +++++++++++++++++-------------
> ----
> user/parlib/include/parlib/dtls.h | 33 ++--
> user/parlib/include/parlib/spinlock.h | 15 +-
> user/parlib/spinlock.c | 17 +-
> user/utest/dtls.c | 105 ++++++++++++
> 6 files changed, 274 insertions(+), 208 deletions(-)
> create mode 100644 user/utest/dtls.c
>
> --
> You received this message because you are subscribed to the Google Groups
> "Akaros" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to [email protected].
> To post to this group, send email to [email protected].
> For more options, visit https://groups.google.com/d/optout.
>
--
You received this message because you are subscribed to the Google Groups
"Akaros" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
For more options, visit https://groups.google.com/d/optout.
