On 2016-08-08 at 19:17 "'Christopher Koch' via Akaros" <[email protected]> wrote: > I updated the 3 later patches (main changes since the first patch set > I sent should be in parlib/debug.c and x86/trap.c). > > https://github.com/brho/akaros/compare/master...hugelgupf:gdbserver-support >
k, i'll take a look at the new stuff (still working through it). you added a couple checkpatch complaints: ------------------------------------------------------------------ ../patches/0002-Defines-protocol-between-gdbserver-and-a-2LS.patch ------------------------------------------------------------------ WARNING: Missing a blank line after declarations #240: FILE: user/parlib/debug.c:249: + struct d9_header *rhdr; + if (pck_len >= UINT_MAX - sizeof(struct d9_header)) total: 0 errors, 1 warnings, 629 lines checked ../patches/0002-Defines-protocol-between-gdbserver-and-a-2LS.patch has style problems, please review. -------------------------------------------------------------------------- ../patches/0003-Asynchronous-client-full-end-to-end-single-threaded-.patch -------------------------------------------------------------------------- WARNING: Missing a blank line after declarations #228: FILE: user/parlib/debug.c:314: + struct d9_header *rpack; + if (debug_fd == -1) WARNING: Missing a blank line after declarations #247: FILE: user/parlib/debug.c:333: + struct d9_header *rpack; + if (debug_fd == -1) On 2016-08-08 at 19:17 "'Christopher Koch' via Akaros" <[email protected]> wrote: > I updated the 3 later patches (main changes since the first patch set > I sent should be in parlib/debug.c and x86/trap.c). > > https://github.com/brho/akaros/compare/master...hugelgupf:gdbserver-support > > The following changes since commit > 18fe89ab8d265ba99e6154eaf807590cfe01279b: > > Import patch to fix shell script/exit status bug. (2016-08-05 > 13:18:07 -0700) > > are available in the git repository at: > > [email protected]:hugelgupf/akaros.git gdbserver-support > > for you to fetch changes up to > 117331dbf8e4df9828a293bae41c3bf462e200c3: > > parlib/debug: Added ability to store memory and single-step. > (2016-08-08 12:07:34 -0700) > > ---------------------------------------------------------------- > Christopher Koch (4): > Moved IDs and added list of threads in uthreads. > Defines protocol between gdbserver and a 2LS. > Asynchronous client; full end-to-end single-threaded debugging > working. > parlib/debug: Added ability to store memory and single-step. > > kern/arch/x86/trap.c > | 21 +++- > tests/Makefile > | 2 +- > tests/block_test.c > | 17 ++-- > tests/futex_timeout.c > | 9 +- > tests/misc-compat.h > | 2 +- > tests/pthread_barrier_test.c > | 13 +-- > tools/compilers/gcc-glibc/glibc-2.19-akaros/sysdeps/akaros/sigaction.c > | 3 +- > user/parlib/debug.c > | 835 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- > user/parlib/include/parlib/debug.h > | 139 +++++++++++++++++++++++++++ > user/parlib/include/parlib/uthread.h > | 7 ++ > user/parlib/include/parlib/x86/debug.h > | 35 +++++++ > user/parlib/include/parlib/x86/trap.h > | 2 + > user/parlib/thread0_sched.c > | 9 +- > user/parlib/uthread.c > | 87 +++++++++++++++-- > user/parlib/x86/debug.c > | 127 +++++++++++++++++++++++++ > user/pthread/pthread.c > | 14 +-- > user/pthread/pthread.h > | 1 - > 17 files changed, 1275 insertions(+), 48 deletions(-) > create mode 100644 user/parlib/include/parlib/debug.h > create mode 100644 user/parlib/include/parlib/x86/debug.h > create mode 100644 user/parlib/x86/debug.c > > On Fri, Aug 5, 2016 at 7:02 PM barret rhoden <[email protected]> > wrote: > > > On 2016-08-05 at 21:20 'Christopher Koch' via Akaros wrote: > > > Hi, > > > > > > Barret - please give a review and don't apply the patches yet. > > > > Will do. > > > > > What's a good place to put the gdbserver docs publicly? Github > > > wiki associated with the repo? Text file in Documentation/? > > > > Documentation sounds good to me. You can start a debugging.txt and > > put a GDB section in there, or just create a gdb.txt. Your > > choice. For a template, check out Documentation/profiling.txt. > > > > Thanks, > > > > Barret > > > > > > -- > > You received this message because you are subscribed to the Google > > Groups "Akaros" group. > > To unsubscribe from this group and stop receiving emails from it, > > send an email to [email protected]. > > To post to this group, send email to [email protected]. > > For more options, visit https://groups.google.com/d/optout. > > -- You received this message because you are subscribed to the Google Groups "Akaros" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. For more options, visit https://groups.google.com/d/optout.
