On 2016-08-22 at 08:12 "Ronald G. Minnich" <[email protected]> wrote:
> The operators took void *, which made it extremely
> hard to debug incorrect usage, which I had a lot of
> in the ahci driver. They are now type safe, e.g.
> a a write to a byte requires a uint8_t*, not a void *.
yikes. was the driver doing stuff like a u32 write to a non-32 byte
alignment?
i'd be happy to merge this, though my slight concern is that these
helpers were linux code, and there might have been a reason it was the
way it was. (like painful casting, or something, in a lot of driver
code).
also:
> -static inline uint8_t __raw_read8(const volatile void __iomem *addr)
> +static inline uint8_t __raw_read8(const volatile uint8_t __iomem *addr) {
> return *(const volatile uint8_t __force *)addr;
Do these still need the cast, since they now take a const vol u8 *?
Barret
--
You received this message because you are subscribed to the Google Groups
"Akaros" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
For more options, visit https://groups.google.com/d/optout.
