Instead of panicking or silently failing.

Signed-off-by: Barret Rhoden <[email protected]>
---

Merged to master at 173c64469274..6fd7915c26e4 (from, to]

You can see the entire diff with 'git diff' or at
https://github.com/brho/akaros/compare/173c64469274...6fd7915c26e4


 kern/drivers/net/bnx2x/bnx2x_dev.c | 1 +
 kern/drivers/net/mlx4/main.c       | 7 +++++--
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/kern/drivers/net/bnx2x/bnx2x_dev.c 
b/kern/drivers/net/bnx2x/bnx2x_dev.c
index 99a880432ac3..bcf7415f26a1 100644
--- a/kern/drivers/net/bnx2x/bnx2x_dev.c
+++ b/kern/drivers/net/bnx2x/bnx2x_dev.c
@@ -127,6 +127,7 @@ static void bnx2x_promiscuous(void *arg, int on)
        edev = arg;
        ctlr = edev->ctlr;
        /* TODO: set promisc on/off */
+       error(EFAIL, "bnx2x promiscuous mode not supported");
 }
 
 static void bnx2x_multicast(void *arg, uint8_t * addr, int add)
diff --git a/kern/drivers/net/mlx4/main.c b/kern/drivers/net/mlx4/main.c
index 93ec0eb0d61f..e4f7c498f658 100644
--- a/kern/drivers/net/mlx4/main.c
+++ b/kern/drivers/net/mlx4/main.c
@@ -3901,8 +3901,11 @@ static void ether_shutdown(struct ether *edev)
 
 static void ether_promiscuous(void *arg, int on)
 {
-       struct ether *edev = arg;
-       panic("Not implemented");
+       struct ether *edev;
+
+       edev = arg;
+       /* TODO: set promisc on/off */
+       error(EFAIL, "mlx4 promiscuous mode not supported");
 }
 
 static void ether_multicast(void *arg, uint8_t *addr, int add)
-- 
2.11.0.483.g087da7b7c-goog

-- 
You received this message because you are subscribed to the Google Groups 
"Akaros" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to