LGTM On Thu, Apr 6, 2017 at 3:21 PM, Barret Rhoden <[email protected]> wrote:
> There are other sync structures in the ipifc that we aren't using. I opted > to keep them around for now (and to initialize them) in case we ever try to > use them for their stated purpose (unbind on the fly). > > Signed-off-by: Barret Rhoden <[email protected]> > --- > kern/src/net/ipifc.c | 5 +++++ > 1 file changed, 5 insertions(+) > > > Merged to master at bd0e783dfc63..67d5328940f2 (from, to] > > You can see the entire diff with 'git diff' or at > https://github.com/brho/akaros/compare/bd0e783dfc63...67d5328940f2 > > > diff --git a/kern/src/net/ipifc.c b/kern/src/net/ipifc.c > index 2ab62be6968f..88915241dc20 100644 > --- a/kern/src/net/ipifc.c > +++ b/kern/src/net/ipifc.c > @@ -343,6 +343,11 @@ static void ipifccreate(struct conv *c) > ifc->unbinding = 0; > ifc->m = NULL; > ifc->reassemble = 0; > + rwinit(&ifc->rwlock); > + /* These are never used, but we might need them if we ever do > "unbind on the > + * fly" (see ip.h). Not sure where the code went that used these > vars. */ > + spinlock_init(&ifc->idlock); > + rendez_init(&ifc->wait); > } > > /* > -- > 2.12.2.715.g7642488e1d-goog > > -- > You received this message because you are subscribed to the Google Groups > "Akaros" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Akaros" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. For more options, visit https://groups.google.com/d/optout.
